Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme origin mismatch warning #1192

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add theme origin mismatch warning #1192

merged 2 commits into from
Jan 6, 2025

Conversation

tarrencev
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jan 6, 2025 6:27pm
ui-next ✅ Ready (Inspect) Visit Preview Jan 6, 2025 6:27pm

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

⚠️ Visual Differences Detected

The following components have visual differences that need review:

components-errorpage--default-chromium

components-errorpage--default-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-connect-createsession--with-preset-chromium

components-connect-createsession--with-preset-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-settings--default-chromium

components-settings--default-chromium

components-connect-authenticate--default-chromium

components-connect-authenticate--default-chromium

components-deploycontroller--default-chromium

components-deploycontroller--default-chromium

components-funding--default-chromium

components-funding--default-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-errorpage--long-error-chromium

components-errorpage--long-error-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-confirmtransaction--default-chromium

components-confirmtransaction--default-chromium

components-connect-upgrade--default-chromium

components-connect-upgrade--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-confirmtransaction--default-chromium

components-confirmtransaction--default-chromium

components-connect-authenticate--default-chromium

components-connect-authenticate--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-connect-createsession--default-chromium

components-connect-createsession--default-chromium

components-connect-createsession--with-preset-chromium

components-connect-createsession--with-preset-chromium

components-connect-upgrade--default-chromium

components-connect-upgrade--default-chromium

components-deploycontroller--default-chromium

components-deploycontroller--default-chromium

components-errorpage--default-chromium

components-errorpage--default-chromium

components-errorpage--long-error-chromium

components-errorpage--long-error-chromium

components-funding--default-chromium

components-funding--default-chromium

components-settings--default-chromium

components-settings--default-chromium


Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--default-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-generic-error-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-light-mode-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-connect-create-createcontroller--with-validation-error-chromium

components-settings--default-chromium

components-settings--default-chromium


Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-settings--default-chromium

components-settings--default-chromium


1 similar comment
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 keychain

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-theme-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-connect-create-createcontroller--with-timeout-error-chromium

components-settings--default-chromium

components-settings--default-chromium


@tarrencev tarrencev merged commit b6d1f66 into main Jan 6, 2025
16 checks passed
@tarrencev tarrencev deleted the verifyorigin branch January 6, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants